chore: added ui/ux improvements in optimize commands #1526
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishalk91-4
requested review from
Souvikns,
Amzani,
Shurtu-gal and
asyncapi-bot-eve
as code owners
|
Hi @Vishalk91-4 thanks for opening this PR, can you update the PR title following https://www.conventionalcommits.org/en/v1.0.0/. |
Vishalk91-4
changed the title
@Souvikns Made the Changes, PTAL |
|
@Vishalk91-4 you have some tests failing, just update the tests according to the changes that you are introducing. |
Signed-off-by: Vishal K <[email protected]>
Vishalk91-4
force-pushed
the
optimize-issue
branch
from
8083655
to
89ec46d
Compare
|
Fixed those errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Resolves #1383